Skip to content

#256 Person outline and portrait styles works with old plantuml.jar versions too #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kirchsth merged 2 commits into from
Nov 21, 2022
Merged

#256 Person outline and portrait styles works with old plantuml.jar versions too #266

kirchsth merged 2 commits into from
Nov 21, 2022

Conversation

@kirchsth
Copy link
Member

@kirchsth kirchsth commented Nov 20, 2022

implement #256 old version plantuml.jar workaround (details see there)

following samples works now with older versions too

@startuml
!includeurl https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Context.puml

Person_Ext(A, "Person A")

SHOW_LEGEND(true)
@enduml
@startuml
!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Context.puml

UpdateElementStyle("person","orange","green","blue", $legendText="Person\ngreen label is only used in legend")
UpdateElementStyle("external_person","gold", "red", "darkred")

' SHOW_PERSON_OUTLINE()
SHOW_PERSON_PORTRAIT()

Person(p, "A person with orange label")
Person_Ext(extP, "An external person with gold label")

SHOW_LEGEND(false)
@enduml

@chriskn can you please test it with my extended branch in your IntelliJ and AsciiDoc environment?

BR Helmut

@kirchsth kirchsth added this to the v2.5.0 milestone Nov 20, 2022
@kirchsth kirchsth requested a review from Potherca November 20, 2022 16:20
@kirchsth kirchsth mentioned this pull request Nov 20, 2022
Closed
@chriskn
Copy link

chriskn commented Nov 20, 2022

@kirchsth it works. I get the following rendering in IntelliJ and AsciiDoc

@startuml

!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Container.puml

SHOW_PERSON_OUTLINE()

Person(version, %version())
Person_Ext(C4Version, C4Version())

SHOW_LEGEND()
@enduml

grafik

Thank you!

The only issue in rendering I still notice is the missing person shape in the legend for external persons, but that's a different and minor issue

@startuml
!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Container.puml

Person(version, %version())
Person_Ext(C4Version, C4Version())

SHOW_LEGEND()
@enduml

grafik

@kirchsth
Copy link
Member Author

kirchsth commented Nov 20, 2022

@chriskn thank you for the review.
I fixed the missing sprite in the legend. Can you please retest it?
BR Helmut

@chriskn
Copy link

chriskn commented Nov 20, 2022

Looks good
grafik

@kirchsth kirchsth merged commit 1a9014b into plantuml-stdlib:master Nov 21, 2022
@kirchsth kirchsth deleted the feature/265-person-workaround branch November 21, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Potherca Potherca Potherca approved these changes

Assignees

No one assigned

Labels

None yet

Projects

All Projects
Status: Done

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kirchsth @chriskn @Potherca